From 2e875ee2123c6dbb5425fa6efe9ba8eed6f64b19 Mon Sep 17 00:00:00 2001 From: Denis Arh Date: Thu, 17 Jan 2019 13:28:55 +0100 Subject: [PATCH] Report metrics field is no longer required --- api/crm/spec.json | 4 ++-- api/crm/spec/module.json | 4 ++-- docs/crm/README.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/api/crm/spec.json b/api/crm/spec.json index 0564031de..c19653426 100644 --- a/api/crm/spec.json +++ b/api/crm/spec.json @@ -341,8 +341,8 @@ { "type": "string", "name": "metrics", - "required": true, - "title": "Metrics (eg: 'COUNT(*) AS count, SUM(money)')" + "required": false, + "title": "Metrics (eg: 'SUM(money), MAX(calls)')" }, { "type": "string", diff --git a/api/crm/spec/module.json b/api/crm/spec/module.json index b45d556a2..4016f9a6a 100644 --- a/api/crm/spec/module.json +++ b/api/crm/spec/module.json @@ -137,8 +137,8 @@ "get": [ { "name": "metrics", - "required": true, - "title": "Metrics (eg: 'COUNT(*) AS count, SUM(money)')", + "required": false, + "title": "Metrics (eg: 'SUM(money), MAX(calls)')", "type": "string" }, { diff --git a/docs/crm/README.md b/docs/crm/README.md index cc323a151..21bd58ab2 100644 --- a/docs/crm/README.md +++ b/docs/crm/README.md @@ -166,7 +166,7 @@ CRM module definitions | Parameter | Type | Method | Description | Default | Required? | | --------- | ---- | ------ | ----------- | ------- | --------- | -| metrics | string | GET | Metrics (eg: 'COUNT(*) AS count, SUM(money)') | N/A | YES | +| metrics | string | GET | Metrics (eg: 'SUM(money), MAX(calls)') | N/A | NO | | dimensions | string | GET | Dimensions (eg: 'DATE(foo), status') | N/A | YES | | filter | string | GET | Filter (eg: 'DATE(foo) > 2010') | N/A | NO | | moduleID | uint64 | PATH | Module ID | N/A | YES |