Add basic intg. tests to compose & system

tests/compose/main_test.go

@@ -0,0 +1,158 @@
+package compose
+
+import (
+	"context"
+	"os"
+	"testing"
+
+	_ "github.com/joho/godotenv/autoload"
+	"github.com/spf13/afero"
+	"github.com/steinfletcher/apitest"
+	"github.com/stretchr/testify/require"
+	"github.com/titpetric/factory"
+
+	"github.com/go-chi/chi"
+	"go.uber.org/zap"
+
+	"github.com/cortezaproject/corteza-server/compose"
+	migrate "github.com/cortezaproject/corteza-server/compose/db"
+	"github.com/cortezaproject/corteza-server/compose/rest"
+	"github.com/cortezaproject/corteza-server/compose/service"
+	"github.com/cortezaproject/corteza-server/compose/types"
+	"github.com/cortezaproject/corteza-server/internal/auth"
+	"github.com/cortezaproject/corteza-server/internal/permissions"
+	"github.com/cortezaproject/corteza-server/internal/rand"
+	"github.com/cortezaproject/corteza-server/internal/store"
+	"github.com/cortezaproject/corteza-server/pkg/api"
+	"github.com/cortezaproject/corteza-server/pkg/cli"
+	"github.com/cortezaproject/corteza-server/pkg/logger"
+	sysTypes "github.com/cortezaproject/corteza-server/system/types"
+	"github.com/cortezaproject/corteza-server/tests/helpers"
+)
+
+type (
+	helper struct {
+		t *testing.T
+		a *require.Assertions
+
+		cUser  *sysTypes.User
+		roleID uint64
+	}
+)
+
+var (
+	cfg *cli.Config
+	r   chi.Router
+	p   = permissions.NewTestService()
+)
+
+func InitConfig() {
+	var err error
+
+	if cfg != nil {
+		return
+	}
+
+	helpers.RecursiveDotEnvLoad()
+
+	ctx := context.Background()
+	log, _ := zap.NewDevelopment()
+
+	cfg = compose.Configure()
+	cfg.Log = log
+
+	cfg.Init()
+
+	auth.SetupDefault(string(rand.Bytes(32)), 10)
+
+	if err = cfg.RootCommandDBSetup.Run(ctx, nil, cfg); err != nil {
+		panic(err)
+	} else if err := migrate.Migrate(factory.Database.MustGet("compose"), log); err != nil {
+		panic(err)
+	}
+
+	logger.SetDefault(log)
+	service.DefaultPermissions = p
+	if service.DefaultStore, err = store.NewWithAfero(afero.NewMemMapFs(), "test"); err != nil {
+		panic(err)
+	}
+
+	cfg.InitServices(ctx, cfg)
+}
+
+func InitApp() {
+	InitConfig()
+	helpers.InitAuth()
+
+	if r != nil {
+		return
+	}
+
+	r = chi.NewRouter()
+	r.Use(api.Base(logger.Default())...)
+	helpers.BindAuthMiddleware(r)
+	rest.MountRoutes(r)
+}
+
+func TestMain(m *testing.M) {
+	InitApp()
+	os.Exit(m.Run())
+}
+
+func newHelper(t *testing.T) helper {
+	h := helper{
+		t:      t,
+		a:      require.New(t),
+		roleID: factory.Sonyflake.NextID(),
+		cUser: &sysTypes.User{
+			ID: factory.Sonyflake.NextID(),
+		},
+	}
+
+	h.cUser.SetRoles([]uint64{h.roleID})
+
+	p.ClearGrants()
+	h.mockPermissionsWithAccess()
+
+	return h
+}
+
+// apitest basics, initialize, set handler, add auth
+func (h helper) apiInit() *apitest.APITest {
+	InitApp()
+
+	return apitest.
+		New().
+		Handler(r).
+		Intercept(helpers.ReqHeaderAuthBearer(h.cUser))
+}
+
+func (h helper) mockPermissions(rules ...*permissions.Rule) {
+	h.a.NoError(p.Grant(
+		// TestService we use does not have any backend storage,
+		context.Background(),
+		// We want to make sure we did not make a mistake with any of the mocked resources or actions
+		service.DefaultAccessControl.Whitelist(),
+		rules...,
+	))
+}
+
+// Prepends allow access rule for compose service for everyone
+func (h helper) mockPermissionsWithAccess(rules ...*permissions.Rule) {
+	rules = append(
+		rules,
+		permissions.AllowRule(permissions.EveryoneRoleID, types.ComposePermissionResource, "access"),
+	)
+
+	h.mockPermissions(rules...)
+}
+
+// Set allow permision for test role
+func (h helper) allow(r permissions.Resource, o permissions.Operation) {
+	h.mockPermissions(permissions.AllowRule(h.roleID, r, o))
+}
+
+// set deny permission for test role
+func (h helper) deny(r permissions.Resource, o permissions.Operation) {
+	h.mockPermissions(permissions.DenyRule(h.roleID, r, o))
+}

tests/compose/permissions_delete_test.go

@@ -0,0 +1,45 @@
+package compose
+
+import (
+	"fmt"
+	"net/http"
+	"testing"
+
+	"github.com/cortezaproject/corteza-server/compose/types"
+	"github.com/cortezaproject/corteza-server/internal/permissions"
+	"github.com/cortezaproject/corteza-server/tests/helpers"
+)
+
+func TestPermissionsDelete(t *testing.T) {
+	h := newHelper(t)
+
+	// Make sure our user can grant
+	h.allow(types.ComposePermissionResource, "grant")
+
+	// New role.
+	permDelRole := h.roleID + 1
+
+	h.a.Len(p.FindRulesByRoleID(permDelRole), 0)
+
+	// Setup a few fake rules for new roke
+	h.mockPermissions(
+		permissions.AllowRule(permDelRole, types.ComposePermissionResource, "access"),
+		permissions.DenyRule(permDelRole, types.ComposePermissionResource, "namespace.create"),
+	)
+
+	h.a.Len(p.FindRulesByRoleID(permDelRole), 2)
+
+	h.apiInit().
+		Delete(fmt.Sprintf("/permissions/%d/rules", permDelRole)).
+		Expect(t).
+		Status(http.StatusOK).
+		Assert(helpers.AssertNoErrors).
+		End()
+
+	// Make sure everything is deleted
+	rr, _ := p.FindRulesByRoleID(permDelRole).Filter(func(r *permissions.Rule) (b bool, e error) {
+		return r.Access != permissions.Inherit, nil
+	})
+
+	h.a.Empty(rr)
+}

tests/compose/permissions_effective_test.go

@@ -0,0 +1,22 @@
+package compose
+
+import (
+	"net/http"
+	"testing"
+
+	"github.com/cortezaproject/corteza-server/compose/types"
+	"github.com/cortezaproject/corteza-server/tests/helpers"
+)
+
+func TestPermissionsEffective(t *testing.T) {
+	h := newHelper(t)
+	h.allow(types.ComposePermissionResource, "access")
+	h.deny(types.ComposePermissionResource, "namespace.create")
+
+	h.apiInit().
+		Get("/permissions/effective").
+		Expect(t).
+		Status(http.StatusOK).
+		Assert(helpers.AssertNoErrors).
+		End()
+}

tests/compose/permissions_list_test.go

@@ -0,0 +1,22 @@
+package compose
+
+import (
+	"net/http"
+	"testing"
+
+	jsonpath "github.com/steinfletcher/apitest-jsonpath"
+
+	"github.com/cortezaproject/corteza-server/tests/helpers"
+)
+
+func TestPermissionsList(t *testing.T) {
+	h := newHelper(t)
+
+	h.apiInit().
+		Get("/permissions/").
+		Expect(t).
+		Status(http.StatusOK).
+		Assert(helpers.AssertNoErrors).
+		Assert(jsonpath.Present(`$.response[? @.resource=="compose"]`)).
+		End()
+}

tests/compose/permissions_read_test.go

@@ -0,0 +1,24 @@
+package compose
+
+import (
+	"fmt"
+	"net/http"
+	"testing"
+
+	"github.com/cortezaproject/corteza-server/compose/types"
+	"github.com/cortezaproject/corteza-server/tests/helpers"
+)
+
+func TestPermissionsRead(t *testing.T) {
+	h := newHelper(t)
+	h.allow(types.ComposePermissionResource, "access")
+	h.allow(types.ComposePermissionResource, "grant")
+	h.deny(types.ComposePermissionResource, "namespace.create")
+
+	h.apiInit().
+		Get(fmt.Sprintf("/permissions/%d/rules", h.roleID)).
+		Expect(t).
+		Status(http.StatusOK).
+		Assert(helpers.AssertNoErrors).
+		End()
+}

tests/compose/permissions_update_test.go

@@ -0,0 +1,22 @@
+package compose
+
+import (
+	"fmt"
+	"net/http"
+	"testing"
+
+	"github.com/cortezaproject/corteza-server/tests/helpers"
+)
+
+func TestPermissionsUpdate(t *testing.T) {
+	h := newHelper(t)
+	h.allow("compose", "grant")
+
+	h.apiInit().
+		Patch(fmt.Sprintf("/permissions/%d/rules", h.roleID)).
+		JSON(`{"rules":[{"resource":"compose","operation":"namespace.create","access":"allow"}]}`).
+		Expect(t).
+		Status(http.StatusOK).
+		Assert(helpers.AssertNoErrors).
+		End()
+}