From 85ae51bf20c2f905b0b434f3873bc2df6e3ef85d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C5=BEe=20Fortun?= <joze.fortun@gmail.com>
Date: Fri, 22 Dec 2023 11:32:46 +0100
Subject: [PATCH 1/2] Revert dedup enabled flag

---
 .../components/Admin/Module/UniqueValues.vue  | 35 +++++++------------
 lib/js/src/compose/types/module.ts            |  2 --
 locale/en/corteza-webapp-compose/module.yaml  |  2 +-
 3 files changed, 13 insertions(+), 26 deletions(-)

diff --git a/client/web/compose/src/components/Admin/Module/UniqueValues.vue b/client/web/compose/src/components/Admin/Module/UniqueValues.vue
index a232b9adc..7b5fad21e 100644
--- a/client/web/compose/src/components/Admin/Module/UniqueValues.vue
+++ b/client/web/compose/src/components/Admin/Module/UniqueValues.vue
@@ -1,36 +1,25 @@
 <template>
   <div>
-    <b-form-group label-class="d-flex align-items-center text-primary p-0">
-      <template #label>
-        {{ $t('enabled') }}
-        <c-hint
-          :tooltip="$t('tooltip.performance')"
-          icon-class="text-warning"
-        />
-      </template>
-
-      <c-input-checkbox
-        v-model="isEnabled"
-        switch
-        :labels="checkboxLabel"
-        data-test-id="checkbox-enabled"
+    <h5 class="d-flex align-items-center mb-3">
+      {{ $t('duplicationDetection') }}
+      <c-hint
+        :tooltip="$t('tooltip.performance')"
+        icon-class="text-warning"
       />
-    </b-form-group>
+    </h5>
 
     <div
       v-for="(rule, index) in rules"
       :key="index"
     >
-      <hr>
-
-      <h5 class="d-flex align-items-center">
+      <label class="d-flex align-items-center text-primary">
         {{ $t('uniqueValueConstraint', { index: index + 1 }) }}
         <c-input-confirm
           show-icon
           class="ml-2"
           @confirmed="rules.splice(index, 1)"
         />
-      </h5>
+      </label>
 
       <div class="d-flex align-items-center justify-content-between flex-wrap w-100">
         <b-form-group>
@@ -132,14 +121,14 @@
           </tbody>
         </b-table-simple>
       </div>
+
+      <hr>
     </div>
 
-    <hr>
-
-    <div class="d-flex justify-content-end">
+    <div class="d-flex">
       <b-button
         variant="outline-light"
-        class="d-flex align-items-center border-0 text-primary"
+        class="d-flex align-items-center border-0 text-primary ml-auto"
         @click="addNewConstraint"
       >
         <font-awesome-icon
diff --git a/lib/js/src/compose/types/module.ts b/lib/js/src/compose/types/module.ts
index 2a1d71c70..4a9ae410a 100644
--- a/lib/js/src/compose/types/module.ts
+++ b/lib/js/src/compose/types/module.ts
@@ -58,7 +58,6 @@ interface Config {
   };
 
   recordDeDup: {
-    enabled: boolean;
     rules: RecordDeDupRule[];
   };
 }
@@ -175,7 +174,6 @@ export class Module {
     },
 
     recordDeDup: {
-      enabled: false,
       rules: [],
     },
   }
diff --git a/locale/en/corteza-webapp-compose/module.yaml b/locale/en/corteza-webapp-compose/module.yaml
index 60f470c35..8b71aa462 100644
--- a/locale/en/corteza-webapp-compose/module.yaml
+++ b/locale/en/corteza-webapp-compose/module.yaml
@@ -190,7 +190,7 @@ edit:
 
     uniqueValues:
       title: Unique values
-      enabled: Enable duplication detection
+      duplicationDetection: Duplication detection
       preventRecordsSave: Prevent record saving if duplicate values are found
       warningLabel: Warning or error message toast when constraint matches
       valueModifiers: Value modifiers

From cbdad33e1c534e3111c8c8245b5e290ff758b2ce Mon Sep 17 00:00:00 2001
From: Peter Grlica <peter.grlica@gmail.com>
Date: Fri, 22 Dec 2023 12:13:23 +0100
Subject: [PATCH 2/2] Remove enabled setting on record deduplication

---
 server/compose/service/record.go | 6 +-----
 server/compose/types/module.go   | 2 --
 server/pkg/provision/dedup.go    | 4 +++-
 3 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/server/compose/service/record.go b/server/compose/service/record.go
index 5d752d929..6b96e5383 100644
--- a/server/compose/service/record.go
+++ b/server/compose/service/record.go
@@ -2025,11 +2025,7 @@ func (svc record) DupDetection(ctx context.Context, m *types.Module, rec *types.
 		config = m.Config.RecordDeDup
 	)
 
-	if !config.Enabled {
-		return
-	}
-
-	if len(config.Rules) > 0 {
+	if len(config.Rules) > 0 && config.Rules.Validate() == nil {
 		records, _, err = svc.Find(ctx, types.RecordFilter{
 			ModuleID:    m.ID,
 			NamespaceID: m.NamespaceID,
diff --git a/server/compose/types/module.go b/server/compose/types/module.go
index 00f431fa0..8ec430d9c 100644
--- a/server/compose/types/module.go
+++ b/server/compose/types/module.go
@@ -90,8 +90,6 @@ type (
 	}
 
 	ModuleConfigRecordDeDup struct {
-		Enabled bool `json:"enabled"`
-
 		// strictly restrict record saving
 		// 		otherwise show a warning with list of duplicated records
 		Strict bool `json:"-"`
diff --git a/server/pkg/provision/dedup.go b/server/pkg/provision/dedup.go
index 635a2481c..b992bef93 100644
--- a/server/pkg/provision/dedup.go
+++ b/server/pkg/provision/dedup.go
@@ -15,12 +15,14 @@ func invalidateDedupRules(ctx context.Context, log *zap.Logger, s store.Storer)
 		return
 	}
 
+	// find only the invalid ones and empty the rules, leave the valid ones
+	// as they were
 	ll, _ = ll.Filter(func(m *types.Module) (bool, error) {
 		return m.Config.RecordDeDup.Rules.Validate() != nil, nil
 	})
 
 	ll.Walk(func(m *types.Module) error {
-		m.Config.RecordDeDup.Enabled = false
+		m.Config.RecordDeDup.Rules = types.DeDupRuleSet{}
 		return nil
 	})