From 070e7516bd72b3f1e340dfeb9890ffb8808e84f4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C5=BEe=20Fortun?= <joze.fortun@gmail.com>
Date: Mon, 26 Feb 2024 16:35:00 +0100
Subject: [PATCH] Fix stale data warning when no stale data

---
 .../src/views/Public/Pages/Records/View.vue   | 33 ++++++++++++-------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/client/web/compose/src/views/Public/Pages/Records/View.vue b/client/web/compose/src/views/Public/Pages/Records/View.vue
index c1ef4f6d6..f92a58166 100644
--- a/client/web/compose/src/views/Public/Pages/Records/View.vue
+++ b/client/web/compose/src/views/Public/Pages/Records/View.vue
@@ -135,13 +135,20 @@ export default {
     record,
   ],
 
-  // Destroy event before route leave to ensure it doesn't destroy the newly created one
   beforeRouteLeave (to, from, next) {
-    this.$root.$off('refetch-record-blocks', this.refetchRecordBlocks)
     this.checkUnsavedChanges(next, to)
   },
 
   beforeRouteUpdate (to, from, next) {
+    const areParamsChanged = JSON.stringify(to.params) !== JSON.stringify(from.params)
+
+    // If the route params have changed, we need to check for unsaved changes
+    // We do this to avoid maginfy block to raise the unsaved changes prompt
+    if (!areParamsChanged) {
+      next()
+      return
+    }
+
     this.checkUnsavedChanges(next, to)
   },
 
@@ -595,7 +602,8 @@ export default {
 
     refetchRecordBlocks () {
       // Don't refresh when creating and prompt user before refreshing when editing
-      if (this.inCreating || (this.inEditing && !window.confirm(this.$t('notification:record.staleDataRefresh')))) {
+      console.log(this.inCreating, this.inEditing, this.compareRecordValues())
+      if (this.inCreating || (this.inEditing && this.compareRecordValues() && !window.confirm(this.$t('notification:record.staleDataRefresh')))) {
         return
       }
 
@@ -650,21 +658,22 @@ export default {
       return !isEqual(recordValues, initialRecordState)
     },
 
-    checkUnsavedChanges (next, to) {
-      if (this.inCreating) {
+    checkUnsavedChanges (next) {
+      if (!this.inEditing) {
         next(true)
-      } else {
-        next(this.compareRecordValues() ? window.confirm(this.$t('general:editor.unsavedChanges')) : true)
+        return
       }
+
+      next(this.compareRecordValues() ? window.confirm(this.$t('general:editor.unsavedChanges')) : true)
     },
 
     checkUnsavedChangesOnModal (bvEvent, modalId) {
-      if (modalId === 'record-modal' && !this.inCreating) {
-        const recordStateChange = this.compareRecordValues() ? window.confirm(this.$t('general:editor.unsavedChanges')) : true
+      if (modalId !== 'record-modal' || !this.inEditing) return
 
-        if (!recordStateChange) {
-          bvEvent.preventDefault()
-        }
+      const recordStateChange = this.compareRecordValues() ? window.confirm(this.$t('general:editor.unsavedChanges')) : true
+
+      if (!recordStateChange) {
+        bvEvent.preventDefault()
       }
     },
   },